[LiveComponent] Fix BC Break when defining LiveProp properties with PHPDoc type and no-native type, when using TypeInfo
#3043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
norkunas
commented
Aug 22, 2025
norkunas
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| Docs? | no |
| Issues | Fix #2963 |
| License | MIT |
carsonbot
added
Bug
|
Hi, Thanks for working on this, could you add a test case and rebase your PR on latest 2.x to make the CI green? Thanks! |
norkunas
force-pushed
the
fix-bc-break
branch
3 times, most recently
from
fb80ce1 to
48fea5c
Compare
Testcase added |
|
Thanks for providing a test, I was finally able to reproduce your issue and observe that indeed a small BC was introduced while working on de302ef |
Kocal
changed the title
LiveProp properties with PHPDoc type and no-native type, when using TypeInfo
Kocal
approved these changes
Aug 27, 2025
carsonbot
added
Status: Reviewed
|
Thank you @norkunas for taking care of this regression. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.